[DOC] Enhanced RDoc for Net::HTTP #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
reviewed
Dec 8, 2022
There was a problem hiding this comment.
It looks like p_no_proxy can reject certain proxies. Some examples:
It can reject a certain address:
http = Net::HTTP.new("example.com", nil, 'proxy.example', 8000, 'pname', 'ppass', "proxy.example")
http.proxy_address # => nilIt can reject certain domains or subdomains:
http = Net::HTTP.new("example.com", nil, 'my.proxy.example', 8000, 'pname', 'ppass', "proxy.example")
http.proxy_address # => nilIt can reject certain addresses and port combinations:
http = Net::HTTP.new("example.com", nil, 'proxy.example', 8000, 'pname', 'ppass', "proxy.example:1234")
http.proxy_address # => "proxy.example"
http = Net::HTTP.new("example.com", nil, 'proxy.example', 8000, 'pname', 'ppass', "proxy.example:8000")
http.proxy_address # => nilIt can reject a list of the types above delimited using a comma:
http = Net::HTTP.new("example.com", nil, 'proxy.example', 8000, 'pname', 'ppass', "my.proxy,proxy.example:8000")
http.proxy_address # => nil
http = Net::HTTP.new("example.com", nil, 'my.proxy', 8000, 'pname', 'ppass', "my.proxy,proxy.example:8000")
http.proxy_address # => nil
|
Added text about p_no_proxy. |
|
Thanks, @peterzhu2118, for your prompt review. I somehow got the notification email marked as read, and so didn't discover til now. |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats:
Caveats:
I've marked several things as :nodoc:, believing them to be obsolete.